Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFLY-19835] Integrate OpenTelemetry with MicroProfile Reactive Messagi… #638

Merged
merged 4 commits into from
Dec 11, 2024

Conversation

kabir
Copy link
Contributor

@kabir kabir commented Oct 18, 2024

@kabir kabir marked this pull request as ready for review November 5, 2024 18:31
@bstansberry bstansberry changed the title [WFLY-19835] Integrate OpenTracing with MicroProfile Reactive Messagi… [WFLY-19835] Integrate OpenTelemetry with MicroProfile Reactive Messagi… Nov 12, 2024

=== Relevant Installation Types

* Traditional standalone server (unzipped or provisioned by Galleon)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not managed domain?

EAP XP doesn't support domain mode, but that is not due to any fundamental technical limitations. And this is WildFly functionality / a WildFly proposal and AFAIK there's no reason this wouldn't work. The relevant extensions are all supported in WildFly domain mode.

https://github.com/wildfly/wildfly/blob/main/galleon-pack/galleon-feature-pack/wildfly-feature-pack-build.xml#L93-L107

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just that in the past (when I did a quick scan) it seemed that we generally don't put domain mode into the MP RFEs. But I can add it domain mode to the list

@kabir kabir force-pushed the WFLY-19835-otel-kafka branch from cebe001 to 4da86f2 Compare November 21, 2024 14:28
* `ON` - Similar to `OFF` but the default is to enable tracing for all channels, unless overridden for the application with the MicroProfile Config properties from the link:#overview[Overview].
* `ALWAYS` - Tracing is enabled for all channels, and can not be turned off with the MicroProfile Config properties from the link:#overview[Overview].

The MicroProfile Config properties in the link:#Overview[Overview], are all booleans, and the values have these meanings:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kabir can you add requirements for channels, connectors and the order of resolution fo the final value like in https://github.com/wildfly/wildfly/pull/18320/files#diff-cb0945fc010a25c215e621bb884a50a79cce48b93356cc7679642ca0364cd00cR399-R410, please?

@darranl darranl merged commit afecfcb into wildfly:main Dec 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants